parallel processing - With OpenMP parallelized nested loops run slow -


i've got part of fortran program consisting of nested loops want parallelize openmp. 

integer :: nstates , n, i, dima, dimb, dimc, a_row, b_row, b_col, c_row, row, col double complex, dimension(4,4):: mat double complex, dimension(:), allocatable :: vecin,vecout   nstates = 2 n = 24  allocate(vecin(nstates**n), vecout(nstates**n)) vecin = ...some data vecout = 0  mat = reshape([...some data...],[4,4])  dimb=nstates**2  !$omp parallel private(dima,dimc,row,col,a_row,b_row,c_row,b_col)  i=1,n-1     dima=nstates**(i-1)     dimc=nstates**(n-i-1)      a_row = 1, dima         b_row = 1,dimb             c_row = 1,dimc                 row = ((a_row-1)*dimb + b_row - 1)*dimc + c_row                 b_col = 1,dimb                     col = ((a_row-1)*dimb + b_col - 1)*dimc + c_row                     !$omp atomic                     vecout(row) = vecout(row) + vecin(col)*mat(b_row,b_col)                 end             end         end     end end !$omp end parallel

the program runs , result correct, it's incredible slow. slower without openmp. don't know openmp. have done wrong use of private or omp atomic? grateful every advice how improve performance of code.

if arrays large , stack overflows automatic reduction, can implement reduction allocatable temporary arrays.

as francois jacq pointed out, have race condition caused dima , dimb should private.

double complex, dimension(:), allocatable :: tmp  !$omp parallel private(dima,dimb,row,col,a_row,b_row,c_row,b_col,tmp)  allocate(tmp(size(vecout))) tmp = 0  !$omp do i=1,n-1     dima=nstates**(i-1)     dimc=nstates**(n-i-1)      a_row = 1, dima         b_row = 1,dimb             c_row = 1,dimc                 row = ((a_row-1)*dimb + b_row - 1)*dimc + c_row                 b_col = 1,dimb                     col = ((a_row-1)*dimb + b_col - 1)*dimc + c_row                     tmp(row) = tmp(row) + vecin(col)*mat(b_row,b_col)                 end             end         end     end end !$omp end  !$omp critical vecout = vecout + tmp !$omp end critical !$omp end parallel

Comments

Post a Comment

Popular posts from this blog

javascript - AngularJS custom datepicker directive -

i make custom datepicker directive custom template. but have no idea how start building it... how include date data directive? i appreciate guide or give me advice work on more precisely. it might you! follow below steps html code sample: <label>birth date</label> <input type="text" ng-model="birthdate" date-options="dateoptions" custom-datepicker/> <hr/> <pre>birthdate = {{birthdate}}</pre> <script type="text/ng-template" id="custom-datepicker.html"> <div class="enhanced-datepicker"> <div class="proxied-field-wrap"> <input type="text" ui-date-format="yy-mm-dd" ng-model="ngmodel" ui-date="dateoptions"/> </div> <label> <button class="btn" type="button"><i class="icon-calendar"></i>
Read more

javascript - jQuery date picker - Disable dates after the selection from the first date picker -

<!doctype html> <html lang="en"> <head> <meta charset="utf-8"> <title>jquery ui datepicker - default functionality</title> <link rel="stylesheet" href="//code.jquery.com/ui/1.11.4/themes/smoothness/jquery-ui.css"> <script src="//code.jquery.com/jquery-1.10.2.js"></script> <script src="//code.jquery.com/ui/1.11.4/jquery-ui.js"></script> <link rel="stylesheet" href="/resources/demos/style.css"> <script> $(function () { $("#datepicker1").datepicker(); }); </script> <script> $(function () { $("#datepicker2").datepicker(); }); </script> </head> <body> <p>date 1: <input type="text" id="datepicker1"></p> <p>date 2: <input type="t
Read more