Binary Search Tree C++ Implementation(dynamic memory problems) -


i learning how implement binary search tree, using more rudimentary c approach(please no "use classes now"). however, there big problem dynamic memory getting deleted. head value gets updated correctly, however, every other point gets deleted. can me? also, nice if offer tips how tighten implementation of tree. basic rundown of program: input character , run 1 of tree's functions. mind though, implementation pure bst, no balancing. thank you.

#include <iostream>  struct point{     point* parent, *left, *right;      int val = -1; };  point* biggest; point empty;  point search(int pos, bool near, point* loc = biggest){     if(loc->val == pos){         return *loc;     } else if(loc->left->val != -1 , loc->val > pos){         return search(pos, near, loc->left);     } else if(loc->right->val != -1){         return search(pos, near, loc->right);     }      if(near){         return *loc;     } else{         point fail;         return fail;     } }  void insert(int pos, point* res){     point loc = search(pos, true);     res->val = pos, res->left = &empty, res->right = &empty, res->parent = &loc;     if(loc.val < res->val){         loc.left = res;     } else{         loc.right = res;     }  }  void remove(int pos){  }  int pred(int pos){     point res = search(pos, false);     if(res.val == -1){         return -1;     }  }  int succ(int pos){     point res = search(pos, false);     if(res.val == -1){         return -1;     }  }  void inorder(point* pos = biggest){     if(pos->left->val != -1){         inorder(pos->left);     }     std::cout << pos->val << " ";     if(pos->right->val != -1){         inorder(pos->right);     } }  int main() {     point start;     start.parent = &empty, start.left = &empty, start.right = &empty;     biggest = &start;     char c;     int pos;     do{         std::cin >> c >> pos;          switch (c){             case 's':                 std::cout << search(pos, false).val << std::endl;                 break;             case 'i':                 if(biggest->val == -1){                     start.val = pos;                 } else{                     point* res = new point;                     insert(pos, res);                 }                 break;             case 'r':                 remove(pos);                 break;             case 'p':                 std::cout << pred(pos) << std::endl;                 break;             case 'n':                 std::cout << succ(pos) << std::endl;                 break;             case 'o':                 inorder();                 std::cout << std::endl;                 break;         }     } while(c != '0');     return 0; }

apart weirdness in code here :

void insert(int pos, point* res){     point loc = search(pos, true);     res->val = pos, res->left = &empty, res->right = &empty;     res->parent = &loc; // <=== here

you modify res->parent point @ local variable loc. after insert() function returns point loc not exist anymore.

also are using classes; c++ structs , classes pretty identical ... apart default member visibility.


Comments

Post a Comment

Popular posts from this blog

cakephp - simple blog with croogo -

i not problem, made simple blog in croogo, problem is not adding or modifying or delete, because arabic language ?? function add in controller `public function admin_add() { $this->set('title_for_layout', __('add part')); if (!empty($this->request->data)) { $this->part->create(); if ($this->part->save($this->request->data)) { $this->session->setflash(__('the part has been saved'), 'default', array('class' => 'success')); $this->redirect(array('action' => 'index'));//, $this->part->id)); } else { $this->session->setflash(__('the part not saved. please, try again.'), 'default', array('class' => 'error')); } } }` => model `class part extends appmodel { public $name = 'part'; var $belongst...
Read more

How to group boxplot outliers in gnuplot -

i have large set of data points. try plot them boxplot, of outliers exact same value , represented on line beside each other. found how set horizontal distance between outliers in gnuplot boxplot , doesn't much, apparently not possible. is possible group outliers together, print 1 point , print number in brackets beside indicate how many points there are? think make more readable in graph. for information, have 3 boxplots 1 x value , times 6 in 1 graph. using gnuplot 5 , played around pointsize, doesn't reduce distance anymore. hope can help! edit: set terminal pdf set output 'dat.pdf' file0 = 'dat1.dat' file1 = 'dat2.dat' file2 = 'dat3.dat' set pointsize 0.2 set notitle set xlabel 'x' set ylabel 'y' header = system('head -1 '.file0); n = words(header) set xtics ('' 1) set [i=1:n] xtics add (word(header, i) i) set style data boxplot plot file0 using (1-0.25):1:(0.2) boxplot lw 2 lc rgb '#8b0000...
Read more

bash - Performing variable substitution in a string -

i have string contains use of variable, , i'd substitute variable's value string. right best have is #!/bin/bash foo='$name; echo bar' name="the name" expanded="$(eval echo "$foo")" echo "$expanded" which has obvious defects: prints the name bar while i'd print the name; echo bar instead of eval can bash's regex matching bash's string replacement: foo='$name; echo bar' name="the name" [[ "$foo" =~ \$([[:alnum:]]+) ]] && s="${!bash_rematch[1]}" && expanded="${foo/\$${bash_rematch[1]}/$s}" echo "$expanded" name; echo bar
Read more